tests - make some tests faster by smaller unit sizes

[bpasero]

This PR fixes #

[joaomoreno]

Wait, won't this just increase both code size as well as overall test runtime? 😕

[bpasero]

See #149712 (comment) for motivation and reasons.

I still think that a unit test doing as little as possible is easier to maintain vs a test that tests more assertions at once.

If there was an argument for many tests slowing things down, then shouldn't a suite just be a single test?

[joaomoreno]

I still think that a unit test doing as little as possible is easier to maintain vs a test that tests more assertions at once.

Agree. But breaking tests apart just for the sake of having the average runtime of tests be lower doesn't make sense.

If there was an argument for many tests slowing things down, then shouldn't a suite just be a single test?

No, the argument is against creating arbitrary boundaries for the sake of lowering the average test runtime. Especially because the tests are now called Test X (1), Test X (2), Test X (3)... If they actually tested different things, that would make much more sense, ie Test X, Test Y, Test Z.