Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic scroll bar mark sequences (OSC 1337 ; SetMark) #151769

Closed
Tyriar opened this issue Jun 10, 2022 · 7 comments · Fixed by #152671
Closed

Support generic scroll bar mark sequences (OSC 1337 ; SetMark) #151769

Tyriar opened this issue Jun 10, 2022 · 7 comments · Fixed by #152671
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 10, 2022

Windows Terminal added this recently, there's a bunch of info/research available on microsoft/terminal#11000 and microsoft/terminal#12948

This may be useful in #150833 depending on how clever we want the task integration to be.

https://iterm2.com/documentation-escape-codes.html

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. labels Jun 10, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 10, 2022
@zadjii-msft
Copy link
Member

lmao I was largely inspired by you guys 😅 I saw https://code.visualstudio.com/updates/v1_65#_terminal-shell-integration and was like yea now this is a good idea

@Tyriar
Copy link
Member Author

Tyriar commented Jun 10, 2022

@zadjii-msft hehe. If you go down the full blown shell integration route I can walk you through all the hacks needed to get it working through conpty 😉, It's working quite well now for pwsh but it took a while to get right.

@Tyriar Tyriar changed the title Support scroll bar mark sequences Support generic scroll bar mark sequences (OSC 1337 ; SetMark) Jun 15, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 15, 2022

If we had a generic mark system we could use them in PartialCommandDetectionCapability so mark decorations show up in the buffer even when shell integration is disabled.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 15, 2022

This would be a good icon for generic marks:

image

@misolori should we add an alias for that and/or create a dot codicon?

@miguelsolorio
Copy link
Contributor

@Tyriar that one is specific to the debug icon as it's overlayed and aligned to fit within another icon. we have other dots but also happy to introduce a smaller one if that is desired:

CleanShot 2022-06-15 at 09 54 43@2x

@Tyriar
Copy link
Member Author

Tyriar commented Jun 15, 2022

@misolori this will be for the naive command detection when shell integration is disabled as well as arbitrary "marks" that either the shell adds or the user does via a command, etc. I figured the little dot would look nice to contrast it strongly with real shell integration (circle-outline and other medium circle icons) and because it's a smaller, more basic version of shell integration.

@miguelsolorio
Copy link
Contributor

Ok, I can add in a request to add a smaller one

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants