Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge editor: fire onDidChangeSizeConstraints when layout changes #151866

Closed
bpasero opened this issue Jun 12, 2022 · 0 comments
Closed

Merge editor: fire onDidChangeSizeConstraints when layout changes #151866

bpasero opened this issue Jun 12, 2022 · 0 comments
Assignees
@jrieken
Labels
insiders-released Patch has been released in VS Code Insiders merge-editor merge-editor-workbench polish Cleanup and polish issue
Milestone
July 2022

Comments

@bpasero
Copy link
Member

bpasero commented Jun 12, 2022

While working on #151836 I noticed that mergeEditor is not yet firing onDidChangeSizeConstraints, which is an event that gets inherited from EditorPane.

The idea is to fire this event when the size constraints of the pane change. This is the case when switching the layout of the merge editor. The workbench editor part can then adjust the size of the editor accordingly in case it is too small to show editors when their constraints change.
@hediet hediet added this to the July 2022 milestone Jun 30, 2022
@jrieken jrieken added polish Cleanup and polish issue feature-request Request for new features or functionality labels Jul 1, 2022
@jrieken jrieken closed this as completed in 2d13e22 Jul 4, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 4, 2022
@jrieken jrieken removed the feature-request Request for new features or functionality label Jul 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
insiders-released Patch has been released in VS Code Insiders merge-editor merge-editor-workbench polish Cleanup and polish issue
Projects
None yet
Milestone
July 2022
Development

No branches or pull requests
4 participants
@bpasero @jrieken @hediet @VSCodeTriageBot