New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use task icon/color in quick pick #151990

Merged

meganrogge merged 10 commits into main from merogge/task-quick-pick

Jun 14, 2022

Contributor

meganrogge commented Jun 13, 2022 •

edited

This PR fixes #151758
fixes #151992

To do:

without API, we can't update the icon / color for tasks like the VS Code build task. Need to make sure the configure icon/color button doesn't show up for these since it won't do anything.

meganrogge added 2 commits

June 13, 2022 14:15


          fix #151758

1af598b


          use tools when color is set and not icon

f219a0c

meganrogge self-assigned this

VSCodeTriageBot added this to the June 2022 milestone


          apply also to configure quickpick

357b8af

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts Outdated Show resolved Hide resolved


          Update src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts

bee7bcd

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts Outdated Show resolved Hide resolved

meganrogge added 2 commits

June 13, 2022 14:37


          Update src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts

131c55a


          fix #151992

d2f275f

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

b0071bf

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

fe77824

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

530df23

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

fee11ea

meganrogge requested review from alexr00 and Tyriar

June 13, 2022 22:55

roblourens approved these changes

View reviewed changes

meganrogge merged commit 33b1980 into main

meganrogge deleted the merogge/task-quick-pick branch

June 14, 2022 01:26

alexr00 reviewed

View reviewed changes

src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts Show resolved Hide resolved

alexr00 reviewed

View reviewed changes

src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts Show resolved Hide resolved

src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts Show resolved Hide resolved

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.