Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support switching to/from custom views in reference-view API #152008

Merged
merged 2 commits into from Aug 19, 2022

Conversation

CsCherrYY
Copy link
Contributor

Signed-off-by: Shi Chen chenshi@microsoft.com

This PR fixes #146037

see also: microsoft/vscode-references-view#74, microsoft/vscode-references-view#75

With this change, we can

Signed-off-by: Shi Chen <chenshi@microsoft.com>
@jrieken jrieken added this to the August 2022 milestone Jul 21, 2022
@jrieken
Copy link
Member

jrieken commented Jul 21, 2022

Sorry - I have been swapped recently and I am now heading out to a longer vacation. My plan is to finally pick this up in August. Thanks for being patient and happy coding

@CsCherrYY
Copy link
Contributor Author

@jrieken never mind, enjoy your vacation!😀

jrieken
jrieken previously approved these changes Aug 19, 2022
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the huge delay here

@jrieken jrieken merged commit a3f5d24 into microsoft:main Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2022
@CsCherrYY CsCherrYY deleted the cs-reference-view-api branch February 10, 2023 05:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make switching between external reference-view and internal reference-view more feasible
3 participants