Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web command to request device access #152310

Merged
merged 5 commits into from Jun 21, 2022
Merged

Add web command to request device access #152310

merged 5 commits into from Jun 21, 2022

Conversation

thegecko
Copy link
Contributor

@thegecko thegecko commented Jun 16, 2022 •
edited

Signed-off-by: thegecko rob.moran@arm.com

This PR reflects the pattern used in #152424 to also expose requests for WebSerial devices via a workbench.experimental.requestSerialPort command and WebHID devices via a workbench.experimental.requestHidDevice command.

cc @mjbvz

@thegecko
Add web command to request serial access
32cc7d0 
Signed-off-by: thegecko <rob.moran@arm.com>
This was referenced Jun 16, 2022
Closed
Closed
@mjbvz
Copy link
Contributor

mjbvz commented Jun 17, 2022

Thanks @thegecko! #152424 moved around the webusb code (extracting it to its own file and cleaning it up). Can you please update this PR to do something similar, perhaps renaming the new usb.ts file to something more generic like deviceAccess.ts?

@mjbvz mjbvz added this to the June 2022 milestone Jun 17, 2022
@thegecko
Copy link
Contributor Author

Can you please update this PR to do something similar, perhaps renaming the new usb.ts file to something more generic like deviceAccess.ts?

Done.

I've also taken the liberty of adding hid support from #152318, but can split that out/remove it if required

@thegecko thegecko changed the title Add web command to request serial access Add web command to request device access Jun 17, 2022
@thegecko thegecko mentioned this pull request Jun 17, 2022
Closed
@mjbvz mjbvz enabled auto-merge (squash) June 20, 2022 20:56
@mjbvz
Copy link
Contributor

mjbvz commented Jun 20, 2022

Thanks!

@thegecko
Copy link
Contributor Author

thegecko commented Jun 21, 2022 •
edited

Can a maintainer approve running the workflows, please?

@mjbvz mjbvz merged commit dd2ca4c into microsoft:main Jun 21, 2022
@thegecko thegecko deleted the webserial branch June 21, 2022 15:18
@beriberikix beriberikix mentioned this pull request Jul 12, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

Assignees

@mjbvz mjbvz

Labels
triage-needed
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thegecko @mjbvz @TylerLeonhardt @VSCodeTriageBot