Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto language detection false positive for ini #152373

Closed
Hacksore opened this issue Jun 16, 2022 · 5 comments
Closed

Auto language detection false positive for ini #152373

Hacksore opened this issue Jun 16, 2022 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug languages-guessing Language guessing issues
Milestone

Comments

@Hacksore
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.68.1
  • OS Version: macOS

Currently, when pasting in a tree-like text payload the model is choosing ini as the language to switch to.

Steps to Reproduce:

  1. Install the tree plugin
  2. Paste in text payload
├── functions
├── src
│    ├── articles
│    ├── components
│    ├── constants
│    ├── contexts
│    ├── data
│    ├── hooks
│    ├── i18n
│    │    └── locales
│    ├── modals
│    │    └── sections
│    ├── pages
│    │    ├── app
│    │    └── r
│    ├── styles
│    ├── templates
│    └── utils
└── static
    └── images
        ├── screenshots
        └── templates

Demo
2022-06-16_13-40-41 (1)

Downstream issues:
microsoft/vscode-languagedetection#9
structure-codes/vscode-tree-language#13

cc @alex-oser

@TylerLeonhardt TylerLeonhardt added languages-guessing Language guessing issues bug Issue identified by VS Code Team member as probable bug labels Jun 17, 2022
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Jun 17, 2022
@djbusby
Copy link

djbusby commented Feb 16, 2023

Is this related to #116729 where the INI files are sometimes read as a 'properties' type? That's where INI then incorrectly chooses '#' as comment rather than ';' like it should

@Hacksore
Copy link
Author

@TylerLeonhardt I'd love to keep this open if we can make forward progress otherwise might just need to close it out.

@TylerLeonhardt
Copy link
Member

We can leave it open. It's on the Backlog meaning it's not actively being worked on... but it should be kept so we don't forget

@Hacksore
Copy link
Author

@TylerLeonhardt I no longer use vscode so this is not relevant for me to keep open anymore.

I'd suggest you aggregate this issue into a shared one with more issues related to language autodetection.

@TylerLeonhardt
Copy link
Member

Fair enough. I'll link this to #166332 and #131450 which do call out issues that guess INI

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-guessing Language guessing issues
Projects
None yet
Development

No branches or pull requests

4 participants