Implements block decorations feature. #152740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
reviewed
Jun 21, 2022
|
|
||
| .monaco-editor .blockDecorations-block { | ||
| position: absolute; | ||
| content: " "; |
There was a problem hiding this comment.
Right, this is not necessary - was a left over. Thanks!
| this.domNode.appendChild(block); | ||
| } | ||
| const top = ctx.getVerticalOffsetForLineNumber(decoration.range.startLineNumber); | ||
| const bottom = ctx.getVerticalOffsetForLineNumber(decoration.range.endLineNumber + 1); |
There was a problem hiding this comment.
This will contain any view zone immediately following this line. If you would like to limit the block strictly to the end line number, you would need to use something like ctx.getVerticalOffsetForLineNumber(decoration.range.endLineNumber) + lineHeight. lineHeight can be found in the editor options.
There was a problem hiding this comment.
Right, good catch. Unfortunately, this is the behavior I need, to cover deleted ranges in the 3wm editor.
I suggest to add a comment and merge it as this and solve the problem when someone does not want to include view zones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.