Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual install of shell integration #152802

Merged
merged 7 commits into from Jun 22, 2022
Merged

Allow manual install of shell integration #152802

merged 7 commits into from Jun 22, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 21, 2022

Fixes #151933

Two main changes:

  • Prevents install script recursion
  • Prevents running profile scripts unless shell integration was injected by VS Code

@Tyriar Tyriar added this to the June 2022 milestone Jun 21, 2022
@Tyriar Tyriar requested a review from meganrogge June 21, 2022 22:05
@Tyriar Tyriar self-assigned this Jun 21, 2022
meganrogge
meganrogge previously approved these changes Jun 22, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 22, 2022

Still have tests I need to fix

@Tyriar Tyriar merged commit 6041abd into main Jun 22, 2022
@Tyriar Tyriar deleted the tyriar/151933 branch June 22, 2022 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow running shell integration scripts inside an rc file
2 participants