Always show overview ruler decorations before command execution #153137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we hid the overview ruler decoration for command currently being input and executed. This ended up causing problems for commands that took a while to run and task decoration support as they would not get a mark in the overview ruler until the command finished. For simplicity let's just always show this, so there will basically always be a grey mark at the very bottom for the cursor line, but that is at least consistent and then we don't need to juggle different overview ruler options depending on the state of the command. Fixes #152663
meganrogge
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we hid the overview ruler decoration for command currently being input
and executed. This ended up causing problems for commands that took a while to run
and task decoration support as they would not get a mark in the overview ruler
until the command finished. For simplicity let's just always show this, so there
will basically always be a grey mark at the very bottom for the cursor line, but
that is at least consistent and then we don't need to juggle different overview
ruler options depending on the state of the command.
Fixes #152663
Task showing the in progress overview ruler decoration:
Terminal showing input line overview ruler decoration: