Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report when search is finished #153464

Merged
merged 1 commit into from Jun 28, 2022
Merged

report when search is finished #153464

merged 1 commit into from Jun 28, 2022

Conversation

sandy081
Copy link
Member

report when search is finished

@sandy081 sandy081 enabled auto-merge (squash) June 28, 2022 12:47
@sandy081 sandy081 self-assigned this Jun 28, 2022
@sandy081 sandy081 requested a review from isidorn June 28, 2022 12:48
@VSCodeTriageBot VSCodeTriageBot added this to the June 2022 milestone Jun 28, 2022
@sandy081
Copy link
Member Author

@isidorn This change reports extensionsView:MarketplaceSearchFinished event when searching Marketplace and the search has finished. While reporting we wait for 2s and report after the current query has finished.

I think 2s is a better heuristic than 1s because we already debounce typing by 500ms. TBH I am also fine increasing it to 3s.

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2022

I just tried it out and it works great. Code also looks good -> approved
@prashantvc fyi so please try it out with VS Code insiders later this week (from tomorrow). Thanks!

@sandy081 sandy081 merged commit 67c2833 into main Jun 28, 2022
@sandy081 sandy081 deleted the sandy081/continuous-hippopotamus branch June 28, 2022 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandy081 @isidorn @VSCodeTriageBot