Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git - Action button precedence #153662

Merged
merged 4 commits into from Jun 29, 2022
Merged

Git - Action button precedence #153662

merged 4 commits into from Jun 29, 2022

Conversation

lszomoru
Copy link
Member

This pull request addresses the feedback that even when all settings of the action button are enabled, there was a scenario (no changes && no incoming/outgoing changes) in which no action button was being displayed in the "Source Control" viewlet.

At the moment we have 3 action buttons:

  1. Commit Changes (enabled/disabled)
  2. Publish Branch
  3. Sync Changes

These buttons are controlled both using the current state of the repository (ex: no changes, no upstream, etc.) as well as settings (SCM/git). In order to create a consistent user experience, we have established the following precedence for the action buttons:

  1. Commit Changes (enabled)
  2. Publish Branch
  3. Sync Changes
  4. Commit Changes (disabled)

@lszomoru lszomoru added the git GIT issues label Jun 29, 2022
@lszomoru lszomoru added this to the June 2022 milestone Jun 29, 2022
@lszomoru lszomoru requested a review from joaomoreno June 29, 2022 10:22
@lszomoru lszomoru self-assigned this Jun 29, 2022
@lszomoru lszomoru merged commit a424998 into main Jun 29, 2022
@lszomoru lszomoru deleted the lszomoru/153504 branch June 29, 2022 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants