Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank Screen on iOS Safari 14.3 #153906

Closed
Idefix2020 opened this issue Jul 1, 2022 · 5 comments · Fixed by #153929
Closed

Blank Screen on iOS Safari 14.3 #153906

Idefix2020 opened this issue Jul 1, 2022 · 5 comments · Fixed by #153929
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@Idefix2020
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: >=1.66.0
  • OS Version: iOS 14.3

Steps to Reproduce:

  1. Open Safari on iOS 14.3
  2. Navigate to any vscode server (e.g. github.dev, vscode.dev or code-server)

The Safari developer tools console shows the following error:

Unhandled Promise Rejection: ReferenceError: Can't find variable: BigInt64Array
@joaomoreno
Copy link
Member

The user is right.

I see references to BigInt64Array in the following commits:

@jrieken Thoughts?

@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 7, 2022
@connor4312
Copy link
Member

As this has been supported since iOS 15, do we want to change this?

@Idefix2020
Copy link
Contributor Author

The changes introduced in 4ac1fc2 completely break vs code for all devices below iOS/iPadOS 15, the other occurrences of BigInt64Array don't seem to have any negative impact according to my testing (anything below 1.66.0 works). The fix I proposed in #153929 is a more elegant solution that supports all browsers and does not break anything.

@jrieken
Copy link
Member

jrieken commented Jul 8, 2022

@jrieken Thoughts?

We are generally only aiming for latest and greatest browser version. The use of BigInt64Array seems small enough to justify a special case but we shouldn't target a lower version nor is there any guarantee that other things won't break, e.g "fixing" this might just reveal another bunch of blocker etc pp.

@joaomoreno joaomoreno assigned rchiodo and unassigned joaomoreno Jul 8, 2022
@joaomoreno
Copy link
Member

Sounds good, forwarding to @rchiodo to evaluate the PR.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 11, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the July 2022 milestone Jul 11, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants