New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add `hide` property to configure which tasks appear in the `Tasks: run task` quickpick #154166

Merged

meganrogge merged 17 commits into main from merogge/hide-tasks

Jul 6, 2022

Contributor

meganrogge commented Jul 5, 2022

This PR fixes #149095


          fix #149095

9193bef

meganrogge requested a review from Tyriar

July 5, 2022 13:57

meganrogge self-assigned this

meganrogge added this to the July 2022 milestone

Tyriar reviewed

View reviewed changes

Member

Tyriar left a comment

Not sure if we should have this vs an actual hidden property as suggested in the related issues? Underscore hiding is somewhat intuitive but much less discoverable.

Contributor Author

meganrogge commented Jul 5, 2022

Yeah I'm not sure which is the right approach. @alexr00 thoughts?

Member

alexr00 commented Jul 5, 2022

I agree that having a property is more discoverable, so I would go for a hidden or hide property. There will inevitably be someone who wants the _ tasks to show, and then you'll also need to add a setting for it.

meganrogge changed the title ~~hide tasks from Tasks: run task quickpick when prefixed with __~~ hide hidden task from Tasks: run task quickpick


          add hide property

af2418a

meganrogge changed the title ~~hide hidden task from Tasks: run task quickpick~~ add hide property to configure which tasks appear in the Tasks: run task quickpick

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

97c7211

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

8492ee8

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

572dc4f

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

bfd17f4

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

62ef13b

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          Update .vscode/tasks.json

ce57998

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved

meganrogge added 3 commits

July 5, 2022 21:37


          Update .vscode/tasks.json

d55967f


          Merge branch 'main' into merogge/hide-tasks


          revert change

9b65041

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

.vscode/tasks.json Outdated Show resolved Hide resolved


          revert changes to task.json

919ee81

meganrogge force-pushed the merogge/hide-tasks branch from 14f33af to 919ee81 Compare

July 6, 2022 01:44


          revert another change

303766a

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/tasks/common/tasks.ts Outdated Show resolved Hide resolved


          Update src/vs/workbench/contrib/tasks/common/tasks.ts

3778d69

Tyriar previously approved these changes

View reviewed changes

src/vs/workbench/api/common/shared/tasks.ts Show resolved Hide resolved

src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts Outdated Show resolved Hide resolved


          quick pick

f544171

meganrogge dismissed Tyriar’s stale review via

f544171

July 6, 2022 14:56

Tyriar approved these changes

View reviewed changes

meganrogge merged commit 0df86c3 into main

meganrogge deleted the merogge/hide-tasks branch

July 6, 2022 15:54

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.