Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove forEach for tasks #154273

Merged
merged 4 commits into from Jul 6, 2022
Merged

remove forEach for tasks #154273

merged 4 commits into from Jul 6, 2022

Conversation

meganrogge
Copy link
Contributor

part of #154195

@meganrogge meganrogge requested a review from Tyriar July 6, 2022 14:41
@meganrogge meganrogge self-assigned this Jul 6, 2022
@meganrogge meganrogge added this to the July 2022 milestone Jul 6, 2022
Tyriar
Tyriar requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer 😃

src/vs/workbench/api/browser/mainThreadTask.ts Outdated Show resolved Hide resolved
@meganrogge @Tyriar
Update src/vs/workbench/api/browser/mainThreadTask.ts
d9f837a 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge enabled auto-merge (squash) July 6, 2022 14:47
@meganrogge meganrogge requested a review from Tyriar July 6, 2022 14:53
Tyriar
Tyriar requested changes Jul 6, 2022
View reviewed changes
src/vs/workbench/contrib/tasks/browser/runAutomaticTasks.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/browser/mainThreadTask.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/browser/mainThreadTask.ts Outdated Show resolved Hide resolved
@meganrogge meganrogge requested a review from Tyriar July 6, 2022 16:33
@meganrogge meganrogge merged commit c133b13 into main Jul 6, 2022
@meganrogge meganrogge deleted the merogge/tasks-foreach branch July 6, 2022 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meganrogge @Tyriar