Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.startupEditor should support opening a terminal in editor area #154366

Closed
ghost opened this issue Jul 7, 2022 · 11 comments
Closed

workbench.startupEditor should support opening a terminal in editor area #154366

ghost opened this issue Jul 7, 2022 · 11 comments
Assignees
Labels
feature-request Request for new features or functionality getting-started terminal Integrated terminal issues

Comments

@ghost
Copy link

ghost commented Jul 7, 2022

I use VS Code as my primary terminal emulator. The first thing I do when opening it is usually to run the workbench.action.createTerminalEditor command so that I can start navigating around, and then using code . to open a project. It would be great if the workbench.startupEditor supported opening a terminal in the editor area.

@ghost
Copy link
Author

ghost commented Jul 7, 2022

FWIW if this wouldn't be too involved I'd be happy to open a PR if you could provide a few pointers to the relevant parts of the code to wire together.

@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

I think this makes sense, moving to @lramos15 as the owner of getting started

@Tyriar Tyriar assigned lramos15 and unassigned Tyriar Jul 7, 2022
@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

fyi @meganrogge

@lramos15
Copy link
Member

@Tyriar Wouldn't you just add terminals to the New File... menu? semantically it might be weird so maybe it should be renamed to New...

@Tyriar
Copy link
Member

Tyriar commented Jul 20, 2022

Feels really weird to have in the New File menu and renaming that just for this would make that action more ambiguous

@lramos15
Copy link
Member

Feels really weird to have in the New File menu and renaming that just for this would make that action more ambiguous

Otherwise it becomes a completely separate entry no?

  • New File...
  • New Terminal in Editor area.

Just feels very specific

@Tyriar
Copy link
Member

Tyriar commented Jul 21, 2022

@lramos15 can we not have it as a startup editor option and not have it in the file menu? There's already the Terminal menu for that

@lramos15
Copy link
Member

@Tyriar Sorry misread the issue and thought this was talking about the getting started startup editor that was default. Yes we can do this

@lramos15 lramos15 added feature-request Request for new features or functionality getting-started labels Jul 21, 2022
@lramos15 lramos15 modified the milestones: July 2022, August 2022 Jul 21, 2022
@lramos15
Copy link
Member

@Tyriar Going to need help from the terminal side of things here. I have created de17d3c but it does not open a terminal due to the fact that you cannot pass in a "untitled" terminal and have one created. I tried to make an arbitrary resource but no terminal is opened

@Tyriar Tyriar modified the milestones: August 2022, Backlog Aug 5, 2022
@sagebind
Copy link

Just like to add that this would also be very useful to me as well. Makes opening a new window with a ready terminal just one click by launching VS Code with no workspace. Like the user who opened the issue, I tend to open workspaces using the code command from a terminal more often than any other method of opening workspaces, simply because I operate out of the terminal a lot just as a default.

Another benefit is that it seems like it just increases the consistency of startupEditor to support something like this.

@bhavyaus bhavyaus self-assigned this Dec 8, 2022
@Tyriar Tyriar added the terminal Integrated terminal issues label Dec 13, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2023

Going to need help from the terminal side of things here. I have created de17d3c but it does not open a terminal due to the fact that you cannot pass in a "untitled" terminal and have one created. I tried to make an arbitrary resource but no terminal is opened

I think this can be solved by deferring to the create terminal in editor area command instead of trying to create a URI. Adjusting assignees...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality getting-started terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

5 participants