Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Commit error after June VS Code update #154449

Closed
Schlermie opened this issue Jul 8, 2022 · 31 comments
Closed

GitHub Commit error after June VS Code update #154449

Schlermie opened this issue Jul 8, 2022 · 31 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release git GIT issues verified Verification succeeded

Comments

@Schlermie
Copy link

Issue Type: Bug

After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.

This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:

[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms]
[2022-07-08T04:36:17.835Z] Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.
[2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms]
[2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.86GB (7.56GB free)
Process Argv --crash-reporter-id b6d5ae76-63a0-48eb-aa8e-87fb9f164435
Screen Reader no
VM 0%
Extensions (6)
Extension Author (truncated) Version
githistory don 0.6.19
python ms- 2022.10.0
vscode-pylance ms- 2022.7.20
jupyter ms- 2022.6.1001902341
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.8
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdc:30486549

@makz159
Copy link

makz159 commented Jul 8, 2022

Issue Type: Bug

After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.

This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:

[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No

System Info
Extensions (6)
A/B Experiments

I have the same issue. I can commit by doing "git commit -m "message for the commit". I guess the issue is that when you just do "F1 - > commit" it doesn't give you the option to supply a message and therefor you get the error " Please supply the message using either -m or -F option."

@lszomoru lszomoru added git GIT issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jul 8, 2022
@makz159
Copy link

makz159 commented Jul 8, 2022

Issue Type: Bug

After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.

This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:

[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No

System Info
Extensions (6)
A/B Experiments

After reading the documentation I now understand the behavior :)
https://code.visualstudio.com/updates/v1_69#_author-commit-message-using-an-editor

so just untick this if you want the old experience
image

@lszomoru
Copy link
Member

lszomoru commented Jul 8, 2022

I have been trying to reproduce this issue in-house without much luck. Would you be able to create a gif recording (https://gifcap.dev) while reproducing the issue? Thank you very much in advance!

@lszomoru lszomoru added candidate Issue identified as probable candidate for fixing in the next release and removed important Issue identified as high-priority labels Jul 8, 2022
@lszomoru lszomoru added this to the June 2022 Recovery 1 milestone Jul 8, 2022
@CryptoCherie
Copy link

ah thank you so much I have been trying to figure out how to fix this 500 error code for 2 days! Go figure all you have to do is untick a box....

@lszomoru
Copy link
Member

lszomoru commented Jul 8, 2022

@CryptoCherie, apologies for the caused inconvenience. While toggling the setting to disable the new flow is a valid workaround, I do want to get to the bottom of the root cause and fix it. Are you able to reproruce the 500 error in all repositories or only some? If only in some, is there anything specific about those repositories? Could you please share a recording (https://gifcap.dev) when you reproduce the issue? Thank you!

@MarkAHamann
Copy link

I get this pressing the new commit button with no text in the textbox using a remote environment where the other side has git version 2.7.4.

It hangs indefinitely, and to recover I need to reload the window.

Ideally, if there I'd no text I'd get a pop-up warning like if I try to commit with no staged changes.

@lszomoru
Copy link
Member

lszomoru commented Jul 8, 2022

@MarkAHamann, thanks for the additional details.
Which extension are you using to connect to the remote environment? Remote-Containers? Remote-SSH? Remote-WSL?

@MarkAHamann
Copy link

Remote-ssh. Windows 10 at my desk connected to Linux beast somewhere in the building.

@MarkAHamann
Copy link

Also, it seems to be opening .git/COMMIT_EDITMSG into my open editors. Empty, of course, because I didn't have a commit message in the text box.

@lszomoru
Copy link
Member

lszomoru commented Jul 8, 2022

@MarkAHamann, if you do not specify a commit message in the input than VS Code will open the COMMIT_EDITMSG file in an editor tab. you can use that to enter the commit message and close the editor to complete the commit operation. Closing the editor when it's contents are empty will cancel the commit operation. Is that the behaviour that you are seeing?

@MarkAHamann
Copy link

Hmm... I hadn't really noticed that new file opening up until later. I just did a commit, got the open file, added a message, hit ctrl-s to save, and now it's still hung indefinitely.

Wait, I just hit the little x to close the editor and it completed.

OK, I see what's going on now. Working as expected (though with new expectations). Pebcak.

@Danniel13
Copy link

[makz159] Thanks a lot my friend @makz159, I could solved this bug c.

@Schlermie
Copy link
Author

@lszomoru See attachment for my gif recording while I reproduce the error. I've got a fairly streamlined setup. I don't have many VS Code extensions beyond Python, Jupyter and Git History. I haven't done any further attempts to rectify the problem since I filed the report last night; however, I now realize the problem seems to stem from my neglect to include a comment with my Commit. It would be nice if VS Code could fail more gracefully though. Thanks for your support.

Recording 2022-07-08 at 19 10 53

@Schlermie
Copy link
Author

Schlermie commented Jul 9, 2022

@lszomoru I confirmed the Commit proceeds successfully if I simply enter a message in the empty Message field directly above the Commit button before I hit the Commit button.

Do you want me to close this ticket or leave it open to track graceful resolution of the error reporting?

@Gauravself
Copy link

Issue Type: Bug

After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.

This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:

[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No

System Info
Extensions (6)
A/B Experiments

Provide a message or text while committing Files

@lszomoru
Copy link
Member

lszomoru commented Jul 9, 2022

@Schlermie, thank you very much for the recording. We should keep the issue opened as this is clearly a problem that I have to address. One should be able to go through the commit flow even if a commit message is not provided as illustrated in the release notes.

@lszomoru
Copy link
Member

lszomoru commented Jul 9, 2022

@Schlermie, could you please reproduce the problem again, and then invoke the Developer: Toggle Developer Tools command and share the contents of the console? I have tracked down that code that fails but I need to understand the exact error that occurs as currenrly we only log the status code. Thank you!

@lszomoru
Copy link
Member

lszomoru commented Jul 9, 2022

I have further looked at the code and my current hypothesis is that we are failing to open the COMMIT_EDITMSG file. At the moment we are assuming that the last argument passed to git-editor-main.ts is the path of this file but I think that assumption might be wrong. I am looking at testing out the fix first in Insiders before we port it to Stable so that it is included in the upcoming recovery release.

@Schlermie, could you please check the version of git that you are using by running git --version? thanks!

@FranciscoPombal
Copy link

Could #154503 be related to this one?

@Schlermie
Copy link
Author

@Schlermie, could you please reproduce the problem again, and then invoke the Developer: Toggle Developer Tools command and share the contents of the console? I have tracked down that code that fails but I need to understand the exact error that occurs as currently we only log the status code. Thank you!

@lszomoru See attachment for my error reproduction, followed by invoking the Developer Tools.

Recording 2022-07-09 at 16 28 09

@Schlermie
Copy link
Author

@Schlermie, could you please check the version of git that you are using by running git --version? thanks!

'git --version' returns this:
git version 2.28.0.windows.1

@babakazizi
Copy link

Issue Type: Bug

After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.

This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:

[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No

System Info
Extensions (6)
A/B Experiments

@Michael-Obele
Copy link

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

After reading the documentation I now understand the behavior :) https://code.visualstudio.com/updates/v1_69#_author-commit-message-using-an-editor

so just untick this if you want the old experience image

Thanks a million, this recent change they made was driving me crazy for the past 2 days. I use custom hot keys to commit and push my code, so I expect the text box to appear and ask for a message. This post just saved my sanity.

@lszomoru
Copy link
Member

Quick update on this issue. I was able to track down the root cause of this failure to cases in which the repository path contains spaces on the path. The fix will be included in tomorrow's Insiders release (2022-07-12), and the Stable recovery release scheduled for later this week. Apologies for the inconvenience caused.

@connor4312
Copy link
Member

@lszomoru closing this for verification since the associated PR was merged.

@ansarianwar
Copy link

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

After reading the documentation I now understand the behavior :) https://code.visualstudio.com/updates/v1_69#_author-commit-message-using-an-editor

so just untick this if you want the old experience image

worked for me. thanks.

@rubensa
Copy link

rubensa commented Jul 12, 2022

@lszomoru I have the same problem with a repository without spaces on the path when I try to do a Commit Staged (Amend) as the message is empty. If I un-check the Git: Use Editor As Commit Input everything works as expected.

This is the git log output:

[2022-07-12T08:48:02.525Z] > git -c user.useConfigOnly=true commit --quiet --amend [63ms]
[2022-07-12T08:48:02.525Z] Error: connect ENOENT /app/tmp/vscode-git-b7bdd1060a.sock
    at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1161:16) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'connect',
  address: '/app/tmp/vscode-git-b7bdd1060a.sock'
}
error: There was a problem with the editor '"/vscode/vscode-server/bin/linux-x64/92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9/extensions/git/dist/git-editor.sh"'.
Please supply the message using either -m or -F option.

NOTE: VSCode v1.69.0 running in a Workspace in a Remote Development Docker container.

@joaomoreno joaomoreno added the verified Verification succeeded label Jul 12, 2022
@lszomoru
Copy link
Member

@rubensa, are you able to reproduce the problem with the latest Insiders release?

@rubensa
Copy link

rubensa commented Jul 12, 2022

@rubensa, are you able to reproduce the problem with the latest Insiders release?

@lszomoru I'll try to check.

@rubensa
Copy link

rubensa commented Jul 12, 2022

@lszomoru It works.
The editor (COMMIT_EDITMSG) is opened with previous commit message but I need to click on the "Accept Commit Message" icon.
If I click on the "Discard Commit Message" icon the commit is cancelled with message "Commit operation was cancelled due to empty commit message." (I expected it to simple use the already commited message, as I'm amending to that).

@Deepakwork07
Copy link

Thanks @makz159 , its resolved at my end

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests