Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlabelled Commit Type Button #154800

Closed
justas2481 opened this issue Jul 11, 2022 · 7 comments
Closed

Unlabelled Commit Type Button #154800

justas2481 opened this issue Jul 11, 2022 · 7 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@justas2481
Copy link

Issue Type: Bug

There is unlabelled button which has arrow down icon that expands the menu of three items - commiting (Commit, Commit & Push and Commit & Sync). Because of this, screen readers do not read / inform what does this button do. Also there is a problem with it's expand / collapse attribute, because this button isn't represented as expandable in the first place. After the first click, it opens the menu with items mentioned and then presents itself as collapsable.

VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Remote OS version: Linux x64 5.15.0-39-generic

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jul 11, 2022
@lszomoru
Copy link
Member

@justas2481, do you mind sharing a screenshot? Thank you!

@justas2481
Copy link
Author

@lszomoru here you go:
1
2

@lszomoru
Copy link
Member

Thank you very much. I will take a look at improving the accessibility of the button this milestone.

@lszomoru lszomoru added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jul 11, 2022
@lszomoru lszomoru added this to the July 2022 milestone Jul 11, 2022
@Dopeman31
Copy link

Fix

@lszomoru
Copy link
Member

@Dopeman31, are you also experiencing this issue as well?

@justas2481, would it be possible for your the try the latest VS Code Insiders release (2022-07-13 or later), as I have made some improvements to the "action button" and I would like to make sure that all your concerns have been addressed. Thank you very much in advamce.

@lszomoru
Copy link
Member

Closing this issue for now. Please feel free to reopen in case you still experience problems with the button. Thanks!

@justas2481
Copy link
Author

@lszomoru It is fixed, sorry for delay, I was really busy.

@alexr00 alexr00 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants