Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot read properties of null (reading 'value') #154944

Merged
merged 1 commit into from Jul 12, 2022
Merged

TypeError: Cannot read properties of null (reading 'value') #154944

merged 1 commit into from Jul 12, 2022

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 12, 2022

Fixes #154757

@alexr00 alexr00 enabled auto-merge (squash) July 12, 2022 15:42
@alexr00 alexr00 self-assigned this Jul 12, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the July 2022 milestone Jul 12, 2022
lramos15
lramos15 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have a precedent for logging to console.error for errors vs console.log but LGTM

@alexr00 alexr00 merged commit 56ae202 into main Jul 12, 2022
@alexr00 alexr00 deleted the alexr00/issue154757 branch July 12, 2022 15:52
@alexr00
Copy link
Member Author

alexr00 commented Jul 12, 2022

Checked with @jrieken on what is normal to do for these checks and he pointed me to

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/common/extHostLanguageFeatures.ts#L1419

which uses console.log.

andreamah pushed a commit that referenced this pull request Jul 14, 2022
@alexr00 @andreamah
TypeError: Cannot read properties of null (reading 'value') (#154944)
d9b95f8 
Fixes #154757
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'value')
3 participants
@alexr00 @lramos15 @VSCodeTriageBot