Add button separator color token #155103
Merged
Add button separator color token #155103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsolorio
commented
Jul 13, 2022
lszomoru
approved these changes
Jul 13, 2022
andreamah
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Add button separator color token * Fix compilation errors
jrieken
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Add button separator color token * Fix compilation errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #152758
This makes the button separator a color token, which is inherited from
button.foregroundto preserve theming, and adds a bit of transparency to reduce the contrast. Themes can override this by settingbutton.separator.Before
After