Polish command navigation for "empty commands" for non-partial terminal capabilities #155551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProKashif
previously approved these changes
Jul 19, 2022
Tyriar
requested changes
Jul 19, 2022
src/vs/workbench/contrib/terminal/browser/xterm/commandNavigationAddon.ts
Outdated
Show resolved
Hide resolved
MonadChains
force-pushed
the
issue/155543
branch
3 times, most recently
from
bbdc71d
to
0d3b073
Compare
MonadChains
force-pushed
the
issue/155543
branch
from
0d3b073
to
a0e4e29
Compare
|
Hi @Tyriar, I have improved the behaviour of the skipping empty commands. |
Tyriar
approved these changes
Sep 2, 2022
alexr00
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #155543
This PR implements the skipping of empty commands in the case of the terminal with non-partial command detection capabilities. The result is:
However in the case of partial command detection capabilities (i.e. IPartialCommandDetectionCapability ) I was not able to implement it. I don't fully understand when terminals with partial detection capabilities occurs, so, I couldn't trigger and investigate them.