Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LabelService - custom formatter function #155641

Merged
merged 3 commits into from Jul 20, 2022
Merged

LabelService - custom formatter function #155641

merged 3 commits into from Jul 20, 2022

Conversation

lszomoru
Copy link
Member

This PR contains:

  1. Use a custom formatter function in the label service
  2. A label formatter for problem markers for the SCM input text document
    image

@lszomoru lszomoru added scm General SCM compound issues label-provider labels Jul 19, 2022
@lszomoru lszomoru added this to the July 2022 milestone Jul 19, 2022
@lszomoru lszomoru requested a review from joaomoreno July 19, 2022 16:58
@lszomoru lszomoru self-assigned this Jul 19, 2022
@lszomoru
Copy link
Member Author

@joaomoreno, let me know if I should add anyone else given the changes to the LabelService.

@lszomoru @joaomoreno
Update src/vs/workbench/contrib/scm/browser/activity.ts
830be10 
Co-authored-by: João Moreno <joao.moreno@microsoft.com>
@lszomoru lszomoru requested a review from joaomoreno July 19, 2022 20:26
@lszomoru lszomoru merged commit 28c40a9 into main Jul 20, 2022
@lszomoru lszomoru deleted the lszomoru/scm-input-label-provider branch July 20, 2022 08:42
lszomoru added a commit that referenced this pull request Jul 25, 2022
@lszomoru
Revert "LabelService - custom formatter function (#155641)"
2d61be2 
This reverts commit 28c40a9.
lszomoru added a commit that referenced this pull request Jul 25, 2022
@lszomoru
Problems view - remove custom code for SCM input markers (#156145)
8dec363 
* Revert "Problems view - Fix issue with the SCM input label provider when problems are displayed in a tree view (#155853)"

This reverts commit e77fa1f.

* Revert "LabelService - custom formatter function (#155641)"

This reverts commit 28c40a9.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@lszomoru lszomoru

Labels
label-provider scm General SCM compound issues
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lszomoru @joaomoreno