Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncDataTree: calling getChildren on collapsed element should not trigger getChildren #155729

Merged
merged 1 commit into from Jul 20, 2022
Merged

AsyncDataTree: calling getChildren on collapsed element should not trigger getChildren #155729

merged 1 commit into from Jul 20, 2022

Conversation

joaomoreno
Copy link
Member

fixes #121567

@joaomoreno joaomoreno enabled auto-merge (squash) July 20, 2022 12:38
@joaomoreno joaomoreno self-assigned this Jul 20, 2022
@joaomoreno joaomoreno requested a review from alexr00 July 20, 2022 12:39
@joaomoreno
Copy link
Member Author

joaomoreno commented Jul 20, 2022 •
edited

@alexr00 Would you mind reviewing and testing it out in your Trees, confirming the change in behavior?

@joaomoreno joaomoreno added this to the July 2022 milestone Jul 20, 2022
alexr00
alexr00 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the box!

@joaomoreno joaomoreno merged commit 0cf530c into main Jul 20, 2022
@joaomoreno joaomoreno deleted the joao/registered-rodent branch July 20, 2022 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

TreeItem getChildren shouldn't be called unless the item is expanded
2 participants
@joaomoreno @alexr00