Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sandbox - deprecate process.pid #155750

Merged
merged 1 commit into from Jul 20, 2022
Merged

sandbox - deprecate process.pid #155750

merged 1 commit into from Jul 20, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jul 20, 2022

No description provided.

@bpasero bpasero enabled auto-merge (squash) July 20, 2022 15:39
@VSCodeTriageBot VSCodeTriageBot added this to the July 2022 milestone Jul 20, 2022
rzhao271
rzhao271 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how this will affect the process explorer? Or, will there be an alternative way to get the child process pids?

@bpasero
Copy link
Member Author

bpasero commented Jul 20, 2022

process.pid is only being used in 1 place so far, I have checked. the process explorer must be using something else to figure out PIDs. It can probably not use process.pid because it works on all processes that are running in VSCode.

@bpasero bpasero merged commit 1c1c0d5 into main Jul 20, 2022
@bpasero bpasero deleted the ben/spontaneous-prawn branch July 20, 2022 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bpasero @rzhao271 @VSCodeTriageBot