Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CommentNode to change body text and enter edit mode at the same time #155767

Merged
merged 1 commit into from Jul 25, 2022

Conversation

joscol
Copy link
Contributor

@joscol joscol commented Jul 20, 2022

This PR addresses #155764

If an extension attempts to change a comment's body and change to edit mode at once, the previous value for the comment body is shown in the edit box.

@rebornix rebornix assigned alexr00 and unassigned rebornix Jul 20, 2022
@alexr00 alexr00 added this to the July 2022 milestone Jul 25, 2022
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems reasonable. Thanks for the PR @joscol!

@alexr00 alexr00 merged commit a30ca5e into microsoft:main Jul 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants