Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Changes button text not centerred #155813

Closed
lszomoru opened this issue Jul 21, 2022 · 4 comments · Fixed by #158167
Closed

Sync Changes button text not centerred #155813

lszomoru opened this issue Jul 21, 2022 · 4 comments · Fixed by #158167
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Using the Amethyst theme the label of the "Sync Changes" button is not vertically aligned:

image

//cc @misolori

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue scm General SCM compound issues labels Jul 21, 2022
@lszomoru lszomoru added this to the August 2022 milestone Jul 21, 2022
@lszomoru lszomoru self-assigned this Jul 21, 2022
@jumboluo
Copy link

That‘s not an issue for me.
The main issue for the "Sync Changes" button is that, it allways shows. It should be hidden when there is no changes to sync.
image

@lszomoru
Copy link
Member Author

@jumboluo, that is unrelated to the problem that this issue is tracking. Also the problem that you are describing has already been fixed in the latest Insiders release, and it will be included in the next Stable release.

@miguelsolorio
Copy link
Contributor

I think this is the same border issue except in the button we cap the height to 30px so it forces everything to be shifted down by 1-2px:

CleanShot 2022-07-21 at 08 43 45@2x

If you remove the height then it looks better:

CleanShot 2022-07-21 at 08 46 01@2x

@lszomoru
Copy link
Member Author

@misolori, thanks for looking into this. your analysis aligns with my findings. I will try to get a fix for this in next week.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 15, 2022
@andreamah andreamah added the verified Verification succeeded label Aug 25, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants