Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show "Accept Merge" only for files currently under conflict. #155822

Merged
merged 1 commit into from Jul 21, 2022

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jul 21, 2022

While the merge editor shows users can handle merge conflicts outside of it, e.g on the console via git add <FILE>. The merge editor should have this graceful and step one is to hide the "Accept Merge" command when the file isn't conflicting anymore

  • Adds a git-context key that contains all resource-uri-strings under conflict
  • Enable/placement of the Accept Merge command is driven by that
  • some merge editor context key sugar

While the merge editor shows users can handle merge conflicts outside of it, e.g on the console via `git add <FILE>`. The merge editor should have this graceful and step one is to hide the "Accept Merge" command when the file isn't conflicting anymore

* Adds a git-context key that contains all resource-uri-strings under conflict
* Enable/placement of the Accept Merge command is driven by that
* some merge editor context key sugar
@jrieken jrieken self-assigned this Jul 21, 2022
@jrieken jrieken enabled auto-merge (squash) July 21, 2022 09:43
@VSCodeTriageBot VSCodeTriageBot added this to the July 2022 milestone Jul 21, 2022
@jrieken jrieken merged commit bbbae59 into main Jul 21, 2022
@jrieken jrieken deleted the joh/powerful-otter branch July 21, 2022 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants