Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃巵 Add support for fish shell history #156058

Merged
merged 9 commits into from Aug 5, 2022
Merged

馃巵 Add support for fish shell history #156058

merged 9 commits into from Aug 5, 2022

Conversation

babakks
Copy link
Contributor

@babakks babakks commented Jul 23, 2022 •
edited

Partially fixes #155530

@babakks
馃巵 Add fish shell history fetch
3e5be58 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
鈿楋笍 Add test to verify fetchFishHistory function
07dfd54 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
馃敤 Include fish shell in history fetch
82b518c 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Tyriar
Tyriar reviewed Jul 24, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm off for a week but will check it out then 馃憤

@Tyriar Tyriar added this to the August 2022 milestone Jul 24, 2022
@babakks
馃敤 Extract sanitizeFishHistoryCmd function for testability
6fcdbd0 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
鈿楋笍 Add unit tests for sanitizeFishHistoryCmd function
0f48e31 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
Copy link
Contributor Author

babakks commented Jul 31, 2022

@Tyriar I updated the PR by extracting the sanitizeFishHistoryCmd function and adding some unit tests to verify its RegExp substitution works correctly.

Tyriar
Tyriar approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @babakks, awesome PR. Just pushed a shell type detection edge case fix I hit.

@Tyriar Tyriar merged commit 9ad7a04 into microsoft:main Aug 5, 2022
@babakks
Copy link
Contributor Author

babakks commented Aug 5, 2022

@Tyriar Happy to hear that. You're welcome.

@babakks babakks deleted the add-fish-history branch August 5, 2022 08:02
@pfitzseb pfitzseb mentioned this pull request Aug 5, 2022
Open
@Tyriar Tyriar mentioned this pull request Aug 5, 2022
Closed
joyceerhl pushed a commit that referenced this pull request Aug 10, 2022
@Tyriar @joyceerhl
Merge pull request #156058 from babakks/add-fish-history
b6f8124 
馃巵 Add support for `fish` shell history
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@joyceerhl joyceerhl joyceerhl approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Support other shell types for terminal shell integration history
3 participants
@babakks @Tyriar @joyceerhl