Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing drop-in-editor API: Extension sample doesn't correctly make list of filenames #156371

Open
andreamah opened this issue Jul 26, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium editor-drag-and-drop Editor UI drag-and-drop operations upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@andreamah
Copy link
Contributor

Testing #156223

When I tried to extension sample, I tried dragging multiple files into the editor and it seemed to only have a list of one item.

I found that the urlList that it gets here doesn't seem to have newlines between the links although the extension uses \n to separate the urls.
https://github.com/microsoft/vscode-extension-samples/blob/b296149e66db76f9a2f63c1d0828a3e3d365c260/drop-on-document/src/extension.ts#L63

Maybe this is just a windows thing? But regardless, the function inserts only one file for me.

@mjbvz mjbvz added this to the August 2022 milestone Aug 3, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels Aug 8, 2022
@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 10, 2022
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) chromium Issues and items related to Chromium labels Sep 26, 2022
@mjbvz
Copy link
Contributor

mjbvz commented Sep 26, 2022

This definitely seems like a chromium bug to me: https://bugs.chromium.org/p/chromium/issues/detail?id=1368361

It does not happen on firefox or on Mac in my testing

Instead of checking in another workaround for this (which I already did for copy/paste), I'm going to mark this bug as upstream so we can hopefully get the root cause addressed

@mjbvz mjbvz modified the milestones: September 2022, On Deck Sep 26, 2022
@mjbvz mjbvz added the editor-drag-and-drop Editor UI drag-and-drop operations label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium editor-drag-and-drop Editor UI drag-and-drop operations upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

2 participants