Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode inline diff peek view doesn't show whitespace difference #156523

Open
abgnwl opened this issue Jul 28, 2022 · 4 comments
Open

VSCode inline diff peek view doesn't show whitespace difference #156523

abgnwl opened this issue Jul 28, 2022 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues
Milestone

Comments

@abgnwl
Copy link

abgnwl commented Jul 28, 2022

Issue Type: Bug

When I change the indentation, Diff Decorations Gutter shows that this line is modified, and "open changes" shows the whitespace difference.

However, when I click the decoration gutter, there is no diff in peek view.

My settings:
SCM: Diff Decorations Ignore Trim Whitespace - false
Diff Editor: Ignore Trim Whitespace - false

Diff Decorations Gutter & peek view:
image

open changes:
image

VS Code version: Code 1.69.2 (3b889b0, 2022-07-18T16:12:52.460Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz (8 x 3000)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.78GB (16.18GB free)
Process Argv C:\Users\zijueli\Desktop\test\1.cpp --crash-reporter-id 887f76a1-42a5-4491-a127-ae98a413d02b
Screen Reader no
VM 0%
Extensions (12)
Extension Author (truncated) Version
code-runner for 0.11.8
better-cpp-syntax jef 1.15.19
vscode-leetcode Lee 0.18.1
sftp lix 1.12.10
vscode-language-pack-zh-hans MS- 1.69.7130921
remote-containers ms- 0.241.3
remote-ssh ms- 0.84.0
remote-ssh-edit ms- 0.80.0
remote-wsl ms- 0.66.3
vscode-remote-extensionpack ms- 0.21.0
cpptools ms- 1.11.4
markdown-preview-enhanced shd 0.6.3

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912:30529769
vsclangdc:30486549
c4g48928:30535728

@alexdima alexdima assigned joaomoreno and lszomoru and unassigned alexdima Jul 28, 2022
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jul 28, 2022
@joaomoreno
Copy link
Member

There's a setting to control this: scm.diffDecorationsIgnoreTrimWhitespace

@joaomoreno joaomoreno closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
@abgnwl
Copy link
Author

abgnwl commented Aug 26, 2022

There's a setting to control this: scm.diffDecorationsIgnoreTrimWhitespace

AFAIK, This setting only affects whether to display the gutter.
I wonder why there is no diff in peek view window

SCM: Diff Decorations Ignore Trim Whitespace - false:
image

SCM: Diff Decorations Ignore Trim Whitespace - true:
image

@joaomoreno joaomoreno removed their assignment Aug 26, 2022
@joaomoreno joaomoreno added scm General SCM compound issues and removed git GIT issues labels Aug 26, 2022
@joaomoreno joaomoreno added this to the Backlog milestone Aug 26, 2022
@joaomoreno
Copy link
Member

You're right! Thanks for the ping!

@joaomoreno joaomoreno reopened this Aug 26, 2022
@abgnwl
Copy link
Author

abgnwl commented Aug 15, 2023

this issue still exists after updating to 1.81.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues
Projects
None yet
Development

No branches or pull requests

4 participants