Skip collapsed state check for nested children when dropping files in explorer #156759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
reviewed
Aug 1, 2022
Tyriar
previously approved these changes
Aug 1, 2022
Semesse
force-pushed
the
nested-file-dnd
branch
from
099cf1c
to
f1927d9
Compare
Semesse
force-pushed
the
nested-file-dnd
branch
from
f1927d9
to
c00ae2c
Compare
lramos15
approved these changes
Aug 1, 2022
rzhao271
approved these changes
Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156746
The error is caused by calling
this.isCollapsed(item)whereitemis a nested child which does not have a corresponding data node but pushed todistinctItemsduring the loop