testing: clean up and compact test result storage #156834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does several chore things around test results: - Removes the persistence of test messages, which should reduce the size of stored results significantly (we only keep the state). This is the same as what IntelliJ does with some cursory testing, and I think it makes sense. - Brings back some of the notion of 'outdated' tests, so previously executed tests are shown in a more muted color. This is useful since they no longer are "full" results, and are instead just messages. - Previous results are no longer 'restored' to the extension host on boot, which directly fixes #151147 - Compacts the storage of terminal output: we'll now only keep the first 100 bytes of any terminal output associated with the test, and read from the disk on-demand when the full message is viewed. Later I want to make terminal messages fancier (see the #terminal channel).
connor4312
force-pushed
the
testing/results-cleanup
branch
from
98192b7
to
04b2fe7
Compare
bpasero
approved these changes
Aug 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several chore things around test results:
size of stored results significantly (we only keep the state). This
is the same as what IntelliJ does with some cursory testing, and I
think it makes sense.
executed tests are shown in a more muted color. This is useful since
they no longer are "full" results, and are instead just messages.
boot, which directly fixes Invalid string length + Unknown actor MainThreadTerminal Service #151147
100 bytes of any terminal output associated with the test, and read
from the disk on-demand when the full message is viewed.
Later I want to make terminal messages fancier (see the #terminal channel).
Fixes #154204 as well