Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

donotRegisterOpenCommand -> doNotRegisterOpenCommand #157070

Merged
merged 2 commits into from Aug 10, 2022
Merged

donotRegisterOpenCommand -> doNotRegisterOpenCommand #157070

merged 2 commits into from Aug 10, 2022

Conversation

joyceerhl
Copy link
Contributor

@joyceerhl joyceerhl enabled auto-merge (squash) August 4, 2022 05:42
@joyceerhl joyceerhl self-assigned this Aug 4, 2022
@joyceerhl joyceerhl requested a review from sandy081 August 4, 2022 05:43
@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 4, 2022
@joyceerhl
Copy link
Contributor Author

There is also donotShowContainerTitleWhenMergedWithContainer which is used in 10 view registrations, but I can't seem to find where this option is read, so I didn't want to camelcase that too in case I missed some subtle way that that option works. @sandy081 do you know whether donotShowContainerTitleWhenMergedWithContainer is still in use and how it's supposed to behave?

ProKashif
ProKashif previously approved these changes Aug 4, 2022
View reviewed changes
@sandy081
Copy link
Member

Yeah I do not see any usage of donotShowContainerTitleWhenMergedWithContainer which means this can be removed. Feel free to remove it.

@joyceerhl joyceerhl merged commit f6a746f into main Aug 10, 2022
@joyceerhl joyceerhl deleted the dev/joyceerhl/advanced-tiger branch August 10, 2022 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanhakabir tanhakabir tanhakabir approved these changes

@ProKashif ProKashif ProKashif left review comments

@sandy081 sandy081 Awaiting requested review from sandy081

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joyceerhl @sandy081 @tanhakabir @ProKashif @VSCodeTriageBot