Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shell decoration icon settings #157094

Merged
merged 2 commits into from Aug 4, 2022
Merged

Remove shell decoration icon settings #157094

merged 2 commits into from Aug 4, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 4, 2022

Fixes #156503

@Tyriar Tyriar added this to the August 2022 milestone Aug 4, 2022
@Tyriar Tyriar requested a review from meganrogge August 4, 2022 14:02
@Tyriar Tyriar self-assigned this Aug 4, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Aug 4, 2022

Need to fix the tests

@Tyriar Tyriar merged commit b91245d into main Aug 4, 2022
@Tyriar Tyriar deleted the tyriar/156503 branch August 4, 2022 21:18
joyceerhl pushed a commit that referenced this pull request Aug 10, 2022
Remove shell decoration icon settings
@aeschli
Copy link
Contributor

aeschli commented Aug 24, 2022

I created #159066 to avoid the direct usage of Codicon.

@aeschli
Copy link
Contributor

aeschli commented Aug 24, 2022

@Tyriar I believe _showChangeIconQuickPick is now dead code after your changes. Removing it would remove the last references to Codicon (I added that to #159066)

@Tyriar
Copy link
Member Author

Tyriar commented Aug 24, 2022

@aeschli yep, thanks 👍

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal decoration icon configuration doesn't go well with icon theming
3 participants