Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laggy scrolling in terminal and editor #157102

Closed
Dominick-Peluso-Bose opened this issue Aug 4, 2022 · 9 comments · Fixed by #165859
Closed

Laggy scrolling in terminal and editor #157102

Dominick-Peluso-Bose opened this issue Aug 4, 2022 · 9 comments · Fixed by #165859
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf terminal-rendering verified Verification succeeded
Milestone

Comments

@Dominick-Peluso-Bose
Copy link

Issue Type: Performance Issue

Ever since I got this M1 mac with apple silicon, any scrolling I do in VSCode is super choppy and laggy. To reproduce it on my machine I just need to open an editor with a scrollbar or a terminal with some history and scroll quickly up and down.

VS Code version: Code 1.69.2 (3b889b0, 2022-07-18T16:32:39.000Z)
OS version: Darwin arm64 21.6.0
Restricted Mode: No

System Info
Item Value
CPUs Apple M1 Max (10 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 4, 5
Memory (System) 32.00GB (4.07GB free)
Process Argv --crash-reporter-id 227dbe86-494d-463f-bc29-f83d8542fc12
Screen Reader no
VM 0%
Process Info
CPU %	Mem MB	   PID	Process
   17	   164	  7103	code main
    0	    98	  7106	   gpu-process
    0	    33	  7108	   utility-network-service
    0	   360	  7109	   window (test_legacy_get_recents.py — svc-bmx-adapter-trio)
    0	   197	  7125	   shared-process
    0	    66	  7127	     ptyHost
    0	     0	  7165	       /bin/zsh -l
    0	    66	  7161	     fileWatcher
    0	     0	  7405	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	   360	  7126	   extensionHost
    0	    66	  7230	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=7126
    0	   197	  7238	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Users/dp1031122/.vscode/extensions/ms-python.vscode-pylance-2022.8.10/dist/server.bundle.js --cancellationReceive=file:b29147689cc6f17bf0ad638db769e1aa6438675d32 --node-ipc --clientProcessId=7126
    0	    98	  7402	   issue-reporter
Workspace Info
|  Window (test_legacy_get_recents.py — svc-bmx-adapter-trio)
|    Folder (svc-bmx-adapter-trio): 181 files
|      File types: yml(30) py(28) json(26) pyc(22) gitignore(5) xml(5) js(4)
|                  md(3) npmrc(2) yaml(2)
|      Conf files: dockerfile(8) package.json(2);
Extensions (11)
Extension Author (truncated) Version
prettier-vscode esb 9.5.0
go gol 0.35.1
githd hui 2.3.3
vscode-docker ms- 1.22.1
python ms- 2022.10.1
vscode-pylance ms- 2022.8.10
jupyter ms- 2022.6.1201981810
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.9
vsliveshare ms- 1.0.5669
vscode-yaml red 1.9.1
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
pylanb8912cf:30529770
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252

@Tyriar
Copy link
Member

Tyriar commented Aug 4, 2022

Can you do a performance profile in devtools (Help > Toggle Developer Tools) and upload it here?

image

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Aug 4, 2022
@Dominick-Peluso-Bose
Copy link
Author

Can you do a performance profile in devtools (Help > Toggle Developer Tools) and upload it here?

Sure, attached.
Profile-20220804T145224.json.zip

@VSCodeTriageBot
Copy link
Collaborator

Hey @Tyriar, this issue might need further attention.

@Dominick-Peluso-Bose, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2022

There's an abnormal about of garbage collection in that profile which I've never seen before:

image

@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2022

@Dominick-Peluso-Bose what sort of monitor are you connected to? Could you also open devtools via the Help menu and run window.devicePixelRatio in the console? My guess is your font size is so large that the terminal's texture atlas is thrashing and redrawing all glyphs almost every frame.

@Tyriar
Copy link
Member

Tyriar commented Oct 24, 2022

Upstream issue tracking the texture cap problem: xtermjs/xterm.js#4061

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug perf terminal-rendering and removed info-needed Issue requires more information from poster labels Oct 24, 2022
@Tyriar Tyriar added this to the Backlog milestone Oct 24, 2022
@Tyriar Tyriar modified the milestones: Backlog, November 2022 Nov 8, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 23, 2022
@Tyriar Tyriar added the author-verification-requested Issues potentially verifiable by issue author label Dec 1, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 1, 2022

This one can only be verified by the @Dominick-Peluso-Bose

@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@Dominick-Peluso-Bose, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version c87fa19 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@rzhao271
Copy link
Contributor

I'll mark this issue as verified as part of #172064. @Dominick-Peluso-Bose Please file a new issue if the bug continues to occur on the latest Stable and/or Insiders versions of VS Code.

@rzhao271 rzhao271 added the verified Verification succeeded label Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf terminal-rendering verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants