Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for borders below Sidebar and Panel titles. #157312

Open
a-stewart opened this issue Aug 5, 2022 · 5 comments · May be fixed by #157318
Open

Add support for borders below Sidebar and Panel titles. #157312

a-stewart opened this issue Aug 5, 2022 · 5 comments · May be fixed by #157318
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues themes Color theme issues
Milestone

Comments

@a-stewart
Copy link
Contributor

a-stewart commented Aug 5, 2022

Hi,

I think it would be useful to add support for a border below sidebar and panel titles.

Eg, current Light High Contrast Theme:

image

It looks a bit odd how the the borders between panels just goes up and meets nothing.

Proposed:

image

I think this border should default to null so be a no-op for regular themes, although, you could make a case for setting it for high contrast themes. My main ask is just to have it as something that can be configured by themes.

@a-stewart
Copy link
Contributor Author

Hi @sbatten - I was wondering if you had an opinion on this change?

I think it could potentially be use to improve the high contrast themes, but even as a no-op as this PR proposes, it allows the option for themes to make use of a border here which would be useful.

@sbatten sbatten added feature-request Request for new features or functionality themes Color theme issues layout General VS Code workbench layout issues labels Oct 24, 2022
@sbatten sbatten added this to the Backlog Candidates milestone Oct 24, 2022
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@a-stewart
Copy link
Contributor Author

Hi @sbatten - with this being something that will only effect theme authors, I think it will struggle to get the 20 votes that a regular feature would.

There is a PR which implements this proposal at #157318 - so this is mainly asking if it is something you think would add value to VS Code for theme authors. I'm happy to make any changes to the PR you think are necessary.

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2022
@sbatten sbatten reopened this Dec 27, 2022
@sbatten sbatten modified the milestones: January 2023, February 2023 Jan 24, 2023
@sbatten sbatten modified the milestones: February 2023, March 2023 Feb 17, 2023
@sbatten sbatten modified the milestones: March 2023, April 2023 Mar 20, 2023
@sbatten sbatten modified the milestones: April 2023, May 2023 Apr 24, 2023
@sbatten sbatten modified the milestones: May 2023, On Deck Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues themes Color theme issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants