labels: fix caching of unintended formatters #157313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
previously approved these changes
Aug 5, 2022
lramos15
approved these changes
Aug 5, 2022
|
This fixes #157056 as well. |
|
Will this be shipped in a recovery release? Thx. |
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
* labels: fix caching of unintended formatters `this.formatters` was the same list instance stored in the memo, so we could cache things we didn't want to. I believe this caused #156135, since things we _intend_ to cache from the extension host are parsed from JSON and cannot be circular. Fixes #156135 * labels: rev label storage to avoid previous bugs Fixes #155844 * fixup! tets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.formatterswas the same list instance stored in the memo, so wecould cache things we didn't want to. I believe this caused #156135,
since things we intend to cache from the extension host are parsed
from JSON and cannot be circular.
Fixes #156135
Fixes #155844