Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo2 Layout Keybinding wrong key used #157407

Open
PythonSmith opened this issue Aug 6, 2022 · 2 comments
Open

Neo2 Layout Keybinding wrong key used #157407

PythonSmith opened this issue Aug 6, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux
Milestone

Comments

@PythonSmith
Copy link

Type: Bug

Configure vscode to use the key codes with the setting keyboard.dispatch.
Try to define a custom key binding of the umlaut "ö".
The neo layout is ignored and the QWERTZ Key x is used.

Because of this bug, it's not possible to map the X and Ö key to different bindings, as they are handled as the same key.
image

If the keyboard dispatch option code is used, the behavior is little different: When "Define Keybinding" is used, the Ö Key is displayed as KeyX, which makes the key binding work correctly. However, the navigation layer of the Neo-Layout is then not working correctly, so using keyboard.dispatch = keyCode is always required.
With the option keyCode it's displayed as just x.

VS Code version: Code 1.70.0 (da76f93, 2022-08-04T04:38:48.541Z) and Code 1.71.0 (73fd3f1)
OS version: Linux x64 5.17.1-051701-generic
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz (8 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 0, 0, 0
Memory (System) 15.42GB (5.66GB free)
Process Argv --unity-launch --crash-reporter-id ebfc1a19-0e2c-4954-ae92-ec2e7ac41a55
Screen Reader no
VM 0%
DESKTOP_SESSION plasma
XDG_CURRENT_DESKTOP KDE
XDG_SESSION_DESKTOP KDE
XDG_SESSION_TYPE x11
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30525688
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vscaac:30438847
pylanb8912:30529769
vsclangdf:30486550
c4g48928:30535728
hb751961:30541207
dsvsc012cf:30540253

@hediet hediet assigned hediet and alexdima and unassigned hediet Aug 7, 2022
@hediet hediet added bug Issue identified by VS Code Team member as probable bug and removed triage-needed new release labels Aug 7, 2022
@hediet hediet added this to the Backlog milestone Aug 7, 2022
@hediet
Copy link
Member

hediet commented Aug 7, 2022

Hello fellow Neo2 user!
I remember that the keyboard layout handling is a bit tricky.

Unfortunately, I am the only Neo2 user in our team and I use windows, where Neo2 keybindings work. Can you debug VS Code and provide more details what doesn't work? Do you have ideas how we can fix this?

@PythonSmith
Copy link
Author

With a bit of debugging I found the main issue which seems to be caused by the Chromium Engine itself:
ö => code=KeyX, key=ö, keyCode=88
x => code=KeyQ, key=x, keyCode=88
j => code=KeyJ, key=n, keyCode=78
Esc => code=Esc, key=Esc, keyCode=27
Esc by Neo Navigation Layer KeyZ => code=KeyZ, key=Esc, keyCode=27
So for the navigation layer to work, the keyCode option needs to be used.
But this will break the keybindings for the umlauts.

@alexdima alexdima added keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux
Projects
None yet
Development

No branches or pull requests

5 participants