Show TreeItem as disabled when command enablement is false #157516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexr00
reviewed
Aug 8, 2022
alexr00
requested changes
Aug 8, 2022
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
Show TreeItem as disabled when command enablement is false
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TreeItem has a command with enablement evaluating to false, show the TreeItem as disabled. #102794
I'm tuning down the opacity (60%) and setting the cursor to default (not pointer). Menu actions on the Node are still displayed with full opacity and the pointer cursor if it's command's enablement is not false.
It would probably make sense to merge this after #157493 has been fixed.