Fix Simplify bash PROMPT_COMMAND handling commit #157631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix @Tyriar commit dfc99af
Simplify bash PROMPT_COMMAND handling
.What's happend ?
I use a modified PS1 for bash prompt:
It works fine without VSCode terminal integration.
$?
return last exit code of command.But, since VSCode 1.7.0,
$?
return value of[[ ${#__vsc_original_prompt_command[@]} -gt 1 ]]
line (line 161).In my case,
$?
return always error.Debug trace:
In my case,
$?
return value of[[ 1 -gt 1 ]]
.fixes #157206