Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize TerminalExitReason API #157653

Merged
merged 1 commit into from Aug 9, 2022
Merged

Finalize TerminalExitReason API #157653

merged 1 commit into from Aug 9, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 9, 2022

Fixes #130231

@Tyriar Tyriar added this to the August 2022 milestone Aug 9, 2022
@Tyriar Tyriar requested a review from meganrogge August 9, 2022 15:11
@Tyriar Tyriar self-assigned this Aug 9, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Aug 9, 2022

fyi @jeanp413

@jeanp413
Copy link
Contributor

jeanp413 commented Aug 9, 2022

Cool, thanks @Tyriar and @meganrogge 🎉

@Tyriar Tyriar merged commit 4d18682 into main Aug 9, 2022
@Tyriar Tyriar deleted the 130231 branch August 9, 2022 16:13
joyceerhl pushed a commit that referenced this pull request Aug 10, 2022
Finalize TerminalExitReason API
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose pty terminal api to detect when it is explicitly killed by a user
3 participants