New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Support other terminals CWD escape sequence #157783
🎁 Support other terminals CWD escape sequence #157783
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, FYI #157570 is a good follow up if you're looking for more
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
…lass Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
…r=<Cwd> ST` Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@Tyriar I applied the reviews. Also, updated the tests (which I hadn't found them earlier because they were under Sequence
|
Seeing how
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this yet but it looks solid! Love the tests 👏
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @babakks 👍
Fixes #157567
Fixes #157568
Fixes #157569
Unfortunately, I couldn't test the terminals/emulators myself. So, take it as an initial implementation. There are some questions, but I decided to submit the PR first and then update it based on the answers.
The questions are regarding the sequence
OSC 7 ; scheme://cwd ST
:scheme://
a literal string or is a placeholder for actual scheme identifier? Naturally it should be the latter.I've put
// TODO
markers to update the code based on the answers:I also added a new helper method
_parseKeyValueAssignment
for parsing key-value assignments. In the existing implementation, we hadn't noticed multiple equal signs (=
) in the command arguments so just splitting and taking the first value would result in a truncated string. This is handled in the_parseKeyValueAssignment
method.