Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Window input box does not execute if IW isn't in focus #157825

Closed
amunger opened this issue Aug 10, 2022 · 0 comments · Fixed by #157923
Closed

Interactive Window input box does not execute if IW isn't in focus #157825

amunger opened this issue Aug 10, 2022 · 0 comments · Fixed by #157923
Assignees
@amunger
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders interactive-window verified Verification succeeded
Milestone
August 2022

Comments

@amunger
Copy link
Contributor

amunger commented Aug 10, 2022

This came up because it can cause flakiness in tests with forcing focus, but also an issue that can occur in production:

IWExecute

We could add arguments for interactive.execute like what we did for interactive.open: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/interactive/browser/interactive.contribution.ts#L336-L370
and https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/common/extHostInteractive.ts#L22-L43
@amunger amunger self-assigned this Aug 10, 2022
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug interactive-window labels Aug 10, 2022
@rebornix rebornix added this to the August 2022 milestone Aug 10, 2022
@amunger amunger mentioned this issue Aug 11, 2022
Merged
@amunger amunger linked a pull request Aug 11, 2022 that will close this issue
add parameter to Interactive Execute to specify resource #157923
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 11, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders interactive-window verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

add parameter to Interactive Execute to specify resource amunger/vscode
4 participants
@rebornix @amunger @rzhao271 @VSCodeTriageBot