improve fish shell integration in vi mode #158127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #139400. Follow-up to #157291.
fish has an additional left-side prompt, which is used in "vi mode" to indicate editor status: if
fish_mode_prompt
is a defined function that produces any output, that output is printed beforefish_prompt
.This PR is based on iTerm2's fish integration, and moves the start-of-prompt escape sequence to prefix
fish_mode_prompt
, if that function is defined and not empty. (The officially documented way to disable the editor status display is to definefunction fish_mode_prompt; end
in your own config.) Otherwise it only modifiesfish_prompt
as before.