Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InlineCompletionItemProvider][Accessibility] Make screen reader read grey text when it shows up #158191

Closed
leti367 opened this issue Aug 15, 2022 · 6 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality inline-completions verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@leti367
Copy link
Member

leti367 commented Aug 15, 2022

We are using grey text api(InlineCompletionItemProvider) for our IntelliCode Completions Extension in VSCode.
We are now working on the accessibility tasks for our extension. We’d like to let the screen readers(like NVDA) to read the grey text when it shows up.
Like in this case:

image

We’d like screen readers to read something like “Suggestions: ‘const functionName = onnxModel.Functions[]’ Tab to accept”. Any ideas/suggestions about how to do this?

We noticed out in VSCode 'Screen Reader Optimized' mode, the tooltip will be like:

image

If user click/select this tooltip, screen reader will read this content. However, is it possible that screen reader can read this info as long as grey texts shows up (even if tooltip doesn’t show up)?

@hediet hediet added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Aug 16, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Aug 16, 2022
@microsoft microsoft deleted a comment from VSCodeTriageBot Aug 16, 2022
@isidorn
Copy link
Contributor

isidorn commented Aug 16, 2022

If the screen reader where to read the grey text whenever it shows up this would be too aggressive and disturbing for our users. Screen reader would read non stop.
That is why my initial thought was that we play an audio cue when there is an inline suggestion, and when users hear this cue if they want they can focus on the hover to hear more.

What do you think about this proposal?

@leti367
Copy link
Member Author

leti367 commented Aug 16, 2022

Thanks @isidorn, this sounds great for me.

@hediet
Copy link
Member

hediet commented Jan 31, 2023

That is why my initial thought was that we play an audio cue when there is an inline suggestion, and when users hear this cue if they want they can focus on the hover to hear more.

I think this is what we have today, can you verify this @isidorn?

@isidorn
Copy link
Contributor

isidorn commented Feb 1, 2023

Yes, there is an audio cue when an inline suggestion is visible.
I also plan to brainstorm about this experience with @meganrogge next week :)

@meganrogge
Copy link
Contributor

@isidorn this is exactly the kind of thing that could be helped with a setting to control the level of detail that we provide the screen reader with #172465

@hediet hediet assigned isidorn and unassigned hediet Apr 4, 2023
@hediet
Copy link
Member

hediet commented Jul 10, 2023

I think this feature is implemented now.

@hediet hediet closed this as completed Jul 10, 2023
@isidorn isidorn modified the milestones: On Deck, July 2023 Jul 10, 2023
@isidorn isidorn added the verification-needed Verification of issue is requested label Jul 10, 2023
@roblourens roblourens added the verified Verification succeeded label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality inline-completions verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants