New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: support associating a profile to a worksapce #158275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up, we should probably look into the code in desktop.main.ts
that deals with the profile:
- how is this supported in web?
- can we optimize entering the profile given we call this so early even before some services are created?
- are there things created before the profile switch that need to update when the profile changes or is that being taken care of already?
- is the code safe for parallel execution? because I can run
code-insiders --profile ...
to restore multiple windows so the code gets executed multiple times?
In web, would be adding
It is well optimised now. But will see if we can optimise further.
Yeah, they are taken care of.
Yes it is. Some of the changes in this PR are meant to handle this. |
Support associating a profile to a workspace from CLI using the argument
--settings-profile
. Profile will be created if not exist. Eg:code <folder/workspace> --settings-profile <name>