Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images with extension in caps don't render #158318

Closed
MaddyDev opened this issue Aug 16, 2022 · 0 comments
Closed

Images with extension in caps don't render #158318

MaddyDev opened this issue Aug 16, 2022 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2022

Comments

@MaddyDev
Copy link
Contributor

This is related to the issue microsoft/azuredatastudio#17404
When rendering an image, it goes to the

vscode/src/vs/platform/protocol/electron-main/protocolMainService.ts

Line 103 in 886ef21

if (this.validExtensions.has(extname(path))) {
and when the extension is valid but in caps it errors.
@MaddyDev MaddyDev mentioned this issue Aug 16, 2022
Merged
@bpasero bpasero self-assigned this Aug 17, 2022
@bpasero bpasero added this to the August 2022 milestone Aug 17, 2022
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 17, 2022
@bpasero bpasero closed this as completed Aug 17, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
4 participants
@bpasero @rzhao271 @MaddyDev @mjbvz