Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EditorResolution.DISABLED #158371

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Remove EditorResolution.DISABLED #158371

merged 3 commits into from
Aug 17, 2022

Conversation

lramos15
Copy link
Member

Fixes #157489

This removed EditorResolution.DISABLED, I tried my best to estimate where to add DEFAULT_EDITOR_ASSOCIATION.id. It also seems like we have a few more places where we should be using the resolver. Is there an easy way to look for deprecated use cases of openEditor

@lramos15 lramos15 self-assigned this Aug 17, 2022
@lramos15 lramos15 requested a review from bpasero August 17, 2022 14:04
@lramos15 lramos15 marked this pull request as ready for review August 17, 2022 14:05
@lramos15 lramos15 added this to the August 2022 milestone Aug 17, 2022
bpasero
bpasero reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why sometimes you cannot pass the group ID into the editor service and have to actually change the code that much?

@lramos15
Copy link
Member Author

Can you clarify why sometimes you cannot pass the group ID into the editor service and have to actually change the code that much?

You can, just using the editorService with typed editor inputs is considered deprecated so I was trying to fix a deprecated use case

@bpasero
Copy link
Member

bpasero commented Aug 17, 2022

Ah yeah, got it!

@lramos15 lramos15 enabled auto-merge (squash) August 17, 2022 18:07
@lramos15 lramos15 merged commit d37e1b9 into main Aug 17, 2022
@lramos15 lramos15 deleted the lramos15/deep-capybara branch August 17, 2022 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Remove EditorResolution.DISABLED
2 participants
@lramos15 @bpasero