adjust width for CJK characters #15838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rebornix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma, @alexandrudima and @jrieken to be potential reviewers. |
alexdima
requested changes
Nov 23, 2016
| @@ -128,6 +129,17 @@ export class ViewCursor { | |||
| this._positionTop = visibleRange.top; | |||
| this._positionLeft = visibleRange.left; | |||
| this._isInViewport = true; | |||
|
|
|||
| let visibleRangeForCharacter = ctx.linesVisibleRangesForRange({ | |||
There was a problem hiding this comment.
@rebornix This extra call should be done only if the cursor style is a block cursor
| @@ -156,6 +168,15 @@ export class ViewCursor { | |||
| this._domNode.setLineHeight(this._lineHeight); | |||
| this._domNode.setHeight(this._lineHeight); | |||
|
|
|||
| let desiredWidth = '1ch'; | |||
There was a problem hiding this comment.
@rebornix Computing the desiredWidth and setting it needs to happen only if the cursor style is set to block.
|
Comments addressed. Only update cursor width if its style is block or underline. @alexandrudima we had issues with underline cursor style as well, which should be taken care of the same way as block cursor. Besides, this fix makes tab more explicit as below
|
alexdima
approved these changes
Nov 29, 2016
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11859 . Read character from view to get the correct width of a character.