Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge editor button missing hover state #158512

Open
miguelsolorio opened this issue Aug 18, 2022 · 1 comment
Open

Merge editor button missing hover state #158512

miguelsolorio opened this issue Aug 18, 2022 · 1 comment
Assignees
@jrieken @alexdima
Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality
Milestone
Backlog

Comments

@miguelsolorio
Copy link
Contributor

CleanShot.2022-08-18.at.10.05.28.mp4

Also: why doesn't this use the button component? Is it because it's part of the editor/monaco, meaning we can't depend on things outside the editor codebase?
@jrieken jrieken assigned alexdima and unassigned hediet Aug 19, 2022
@jrieken
Copy link
Member

jrieken commented Aug 19, 2022

Also: why doesn't this use the button component? Is it because it's part of the editor/monaco

Adding @alexdima for that but my guess is that this button predates the button component. Things from base/ can be used in editor/

@alexdima alexdima added feature-request Request for new features or functionality editor-contrib Editor collection of extras labels Aug 19, 2022
@alexdima alexdima added this to the Backlog milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

@alexdima alexdima

Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jrieken @hediet @alexdima @miguelsolorio